Skip to content

Define protocols for connection type overrides #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

Define protocols for connection type overrides #33

merged 1 commit into from
Jun 1, 2020

Conversation

markedwards
Copy link
Contributor

Resolves #32

@markedwards markedwards requested a review from Cito as a code owner May 18, 2020 12:32
Cito
Cito reviewed May 20, 2020
View reviewed changes
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should require typing-extensions only for Py < 3.8 (see #31).

When importing Protocol, first try importing from typing. If that fails, import from typing_extensions, if that fails, use Any instead.

@markedwards markedwards force-pushed the type_override_protocols branch from 7a09d29 to fabf714 Compare May 31, 2020 17:04
@markedwards
Copy link
Contributor Author

@Cito, I've implemented the requested changes. Let me know if you would like to see any other improvements.

@Cito Cito merged commit 4865837 into graphql-python:master Jun 1, 2020
@Cito
Copy link
Member

Cito commented Jun 1, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type checking fails when using constructor overrides in arrayconnection.py
2 participants
@markedwards @Cito